Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow LLD to process bitcode for SBF #111

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Allow LLD to process bitcode for SBF #111

merged 2 commits into from
Nov 19, 2024

Conversation

LucasSte
Copy link
Collaborator

@LucasSte LucasSte commented Nov 19, 2024 •
edited
Loading

The change is simply an addition in function getBitcodeMachineKind. This is necessary to enable LTO.

@LucasSte LucasSte marked this pull request as ready for review November 19, 2024 17:17
@LucasSte LucasSte requested a review from dmakarov November 19, 2024 18:55
dmakarov
dmakarov approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@dmakarov dmakarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had LTO enabled at some point and that broke some of the downstream projects. We need to be cautious enabling it again.

@LucasSte LucasSte merged commit 26ccb0c into anza-xyz:solana-rustc/18.1-2024-05-19 Nov 19, 2024
5 checks passed
@LucasSte LucasSte deleted the bitcode-process branch November 19, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmakarov dmakarov dmakarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasSte @dmakarov