[SOL] Implement syscall instruction #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
approved these changes
Dec 18, 2024
LucasSte
commented
Dec 18, 2024
Comment on lines
+29
to
+36
| ; Syscall declaration in Rust: | ||
| ; | ||
| ; #[no_mangle] | ||
| ; pub unsafe fn rust_declaration(b: u64) -> u32 { | ||
| ; let syscall : extern "C" fn(b: u64) -> u32 = core::mem::transmute(60u64); | ||
| ; return syscall(b); | ||
| ; } | ||
| ; The following is the unoptimized output from rustc: |
There was a problem hiding this comment.
In some circumstances, specially when we build the code with -O0, the front end may emit a callx. Instead of creating a peephole or forcing optimizations in the backend, I decided to add the correct declaration example in both C and Rust.
These examples generate LLVM-IR code that even when unoptimized will create a syscall instruction.
Lichtso
approved these changes
Dec 18, 2024
LucasSte
merged commit 26f146b
into
anza-xyz:solana-rustc/18.1-2024-05-19
15 checks passed
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Feb 13, 2025
* Implement static syscalls * Rename syscall and return * Remove external call from v3 and use pointer value directly
LucasSte
added a commit
that referenced
this pull request
Apr 8, 2025
* Implement static syscalls * Rename syscall and return * Remove external call from v3 and use pointer value directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIMD-0178 introduces a
syscallinstruction which comprises the opcode0x95and an immediate value. The value is supposed to be an integer greater than zero, representing the syscall we want to invoke.Following the external call scheme on BPF, we'll consider a syscall any call to a static address.
The reason behind this design was to avoid compile work when introducing of a syscall. Identifying syscalls by their symbol name would required either a hard coded lookup table or loading an external file. The former case would require a toolchain recompilation and the latter a new platform tools release simply to add a syscall, increasing the work overhead.
The front-end must specify the syscall header as a constant function pointer and assign to it the corresponding syscall number. This is similar to existing scheme for static syscalls, except that we won't be using the murmur32 hash anymore. Syscalls should be declared as the following example: