feat(io): impl Reader for BufReader + add ReadAdapter#54
Merged
Conversation
cpubot
force-pushed
the
buf-reader-no-grow
branch
4 times, most recently
from
38d14f7 to
80aed37
Compare
cpubot
changed the title
cpubot
changed the title
cpubot
changed the title
BufReader for std::io::Read
cpubot
force-pushed
the
buf-reader-no-grow
branch
from
80aed37 to
56e1268
Compare
cpubot
force-pushed
the
buf-reader-no-grow
branch
from
56e1268 to
20d572e
Compare
cpubot
changed the title
BufReader for std::io::Read
cpubot
force-pushed
the
buf-reader-no-grow
branch
2 times, most recently
from
31b798c to
c43ecc4
Compare
cpubot
force-pushed
the
buf-reader-no-grow
branch
from
c43ecc4 to
ca19e16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
Readerimplementation,ReadAdapter, over anystd::io::Readand implementsReaderforstd::io::BufReader.I am favoring the simple implementation over something more sophisticated like #196 unless we can prove there is a performance benefit to it.
Closes #50