Skip to content
This repository was archived by the owner on Jul 11, 2019. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/protractorAppender.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function protractorAppender(consoleLog) {

function resolveAllPromises(dataParts) {
var promises = dataParts.map(function (value) {
if (value.then) {
if (!!value && value.then) {
return value;
} else {
return global.protractor.promise.when(value);
Expand Down
26 changes: 26 additions & 0 deletions test/protractorAppender-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,31 @@ describe('protractorAppender', function () {
deferred.fulfill('World');
}, 50);
});

it('should handle undefined in the log event', function (done) {
global.browser = protractorMock;
event.data.push(undefined);

appender(event).then(function () {
expect(consoleMock).toHaveBeenCalledWith({
data: ['Hello', undefined],
startTime: jasmine.any(Date)
});
done();
});
});

it('should handle null value in the log event', function (done) {
global.browser = protractorMock;
event.data.push(null);

appender(event).then(function () {
expect(consoleMock).toHaveBeenCalledWith({
data: ['Hello', null],
startTime: jasmine.any(Date)
});
done();
});
});
});
});