Draft for supporting DBLP KG #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reham-Osama
commented
Apr 3, 2024
| @@ -122,9 +122,9 @@ public static ArrayList<Predicate> getAvailablePredicates(boolean order) { | |||
| predicate.setPredicateURI(result.getString("PredicateURI")); | |||
| predicate.setPredicateContext(new PredicateContext(result.getString("Context_Subject"), result.getString("Context_Object"), 0)); | |||
| predicate.setWeight(result.getLong("ContextWeight")); | |||
| if (!predicate.getPredicateURI().contains("#")) { | |||
| // if (!predicate.getPredicateURI().contains("#")) { | |||
There was a problem hiding this comment.
I made this change because most of the dblp predicates contains #, Do you think that this will affect the overall performance?
Reham-Osama
commented
Apr 3, 2024
| @@ -53,7 +53,7 @@ public static void generateShapes() throws Exception { | |||
|
|
|||
| int benchmarkNumber = 37; | |||
|
|
|||
| for (int j = 480; j < 10000; j = j + 10) { | |||
| for (int j = 0; j < 10000; j = j + 10) { | |||
There was a problem hiding this comment.
I changed this to be able to have some results on DBLP. Without it, I was receiving no output files
Will this affect the performance or the output ?
Reham-Osama
commented
Apr 3, 2024
| } | ||
| } | ||
|
|
||
| private ArrayList<VariableSet> filterResult( ArrayList<VariableSet> result) { |
There was a problem hiding this comment.
I added this method because querying the RDF engine using the unwantedPropertiesString returned no results at all, so I returned all predicates and removed the unneeded using this method
I called it from getPredicateList_EntityObjects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an explanation for why I made my changes within the code.
I have a couple of questions related to these changes