-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft for supporting DBLP KG #4
base: main
Are you sure you want to change the base?
Conversation
@@ -122,9 +122,9 @@ public static ArrayList<Predicate> getAvailablePredicates(boolean order) { | |||
predicate.setPredicateURI(result.getString("PredicateURI")); | |||
predicate.setPredicateContext(new PredicateContext(result.getString("Context_Subject"), result.getString("Context_Object"), 0)); | |||
predicate.setWeight(result.getLong("ContextWeight")); | |||
if (!predicate.getPredicateURI().contains("#")) { | |||
// if (!predicate.getPredicateURI().contains("#")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this change because most of the dblp predicates contains #
, Do you think that this will affect the overall performance?
@@ -53,7 +53,7 @@ public static void generateShapes() throws Exception { | |||
|
|||
int benchmarkNumber = 37; | |||
|
|||
for (int j = 480; j < 10000; j = j + 10) { | |||
for (int j = 0; j < 10000; j = j + 10) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to be able to have some results on DBLP. Without it, I was receiving no output files
Will this affect the performance or the output ?
} | ||
} | ||
|
||
private ArrayList<VariableSet> filterResult( ArrayList<VariableSet> result) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this method because querying the RDF engine using the unwantedPropertiesString
returned no results at all, so I returned all predicates and removed the unneeded using this method
I called it from getPredicateList_EntityObjects
I added an explanation for why I made my changes within the code.
I have a couple of questions related to these changes