ARTEMIS-5142 setting 0 for min/max expiry-delivery not working as expected #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabish121
reviewed
Nov 1, 2024
| @@ -92,6 +92,7 @@ public class JDBCSequentialFile implements SequentialFile { | |||
| this.filename = filename; | |||
| this.extension = filename.contains(".") ? filename.substring(filename.lastIndexOf(".") + 1, filename.length()) : ""; | |||
| this.executor = executor; | |||
| new Exception(driver.toString()).printStackTrace(); | |||
There was a problem hiding this comment.
This seems like it was not supposed to make it into the PR ?
jbertram
force-pushed
the
ARTEMIS-5142
branch
from
299337e
to
af99bb4
Compare
gemmellr
reviewed
Nov 1, 2024
pom.xml
Outdated
|
The min and max settings aren't listed in the address-settings doc, might be good to add them with this. (They are covered in the expiry section referenced from the address setting doc for the other expiry setting). |
jbertram
force-pushed
the
ARTEMIS-5142
branch
from
af99bb4
to
81ad29f
Compare
|
@gemmellr, I took care of the documentation. |
jbertram
force-pushed
the
ARTEMIS-5142
branch
from
81ad29f
to
a02194b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.