Skip to content

Commit

Permalink
Add attributes to display total number of queues and topics
Browse files Browse the repository at this point in the history
  • Loading branch information
kenliao94 committed Oct 25, 2024
1 parent 5b93d24 commit 15186e8
Show file tree
Hide file tree
Showing 3 changed files with 81 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -280,11 +280,21 @@ public ObjectName[] getTopics() {
return safeGetBroker().getTopicsNonSuppressed();
}

@Override
public int getTotalTopicsCount() {
return getTopics().length;
}

@Override
public ObjectName[] getQueues() {
return safeGetBroker().getQueuesNonSuppressed();
}

@Override
public int getTotalQueuesCount() {
return getQueues().length;
}

@Override
public String queryQueues(String filter, int page, int pageSize) throws IOException {
return DestinationsViewFilter.create(filter)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,17 @@ public interface BrokerViewMBean extends Service {
@MBeanInfo("Topics (broadcasted 'queues'); generally system information.")
ObjectName[] getTopics();

@MBeanInfo("Total number of topics")
int getTotalTopicsCount();


@MBeanInfo("Standard Queues containing AIE messages.")
ObjectName[] getQueues();

@MBeanInfo("Total number of queues")
int getTotalQueuesCount();


/**
* Queue Query API, take a look at {@link DestinationsViewFilter} for more information
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.activemq.broker.jmx;

import jakarta.jms.*;
import jakarta.jms.Connection;
import org.apache.activemq.*;
import org.apache.activemq.broker.*;
import org.apache.activemq.util.*;
import org.junit.*;

import static org.junit.Assert.assertTrue;

public class BrokerViewTest {
protected BrokerService brokerService;
protected ActiveMQConnectionFactory factory;
protected Connection producerConnection;

protected Session producerSession;
protected MessageConsumer consumer;
protected MessageProducer producer;
protected Queue queue;

@Before
public void setUp() throws Exception {
brokerService = new BrokerService();
brokerService.setPersistent(false);
brokerService.start();

factory = new ActiveMQConnectionFactory(BrokerRegistry.getInstance().findFirst().getVmConnectorURI());
producerConnection = factory.createConnection();
producerConnection.start();
producerSession = producerConnection.createSession(false, Session.AUTO_ACKNOWLEDGE);
Queue queue = producerSession.createQueue("testQueue");
producer = producerSession.createProducer(queue);
producer.send(producerSession.createTextMessage("testMessage"));
}

@Test(timeout=120000)
public void testBrokerViewRetrieveTotalQueuesAndTopicsCount() throws Exception {
assertTrue(Wait.waitFor(() -> (brokerService.getAdminView()) != null));

final BrokerView view = brokerService.getAdminView();
// The total number of advisory topics
assert(view.getTotalTopicsCount() == 4);
// The queue created in setup
assert(view.getTotalQueuesCount() == 1);
}
}

0 comments on commit 15186e8

Please sign in to comment.