Skip to content

[#] JDK 25 support (multiple JIRA) #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[#] JDK 25 support (multiple JIRA) #1533

wants to merge 6 commits into from

Conversation

@mattrpav
Copy link
Contributor

@mattrpav mattrpav commented Nov 13, 2025 •
edited
Loading

Apache Jenkins JDK 25 test passed except for two tests

TODO:

  • JmsSchedulerTest.testUpdatesAppliedToIndexBeforeJournalShouldBeDiscarded failing -- log4j2 test appender is not picking up events, but everything is working correctly
  • JmsSchedulerTest.testCron is hanging indefinitely

ref: https://ci-builds.apache.org/job/ActiveMQ/job/ActiveMQ/job/PR-1533/6/

@mattrpav mattrpav self-assigned this Nov 13, 2025
jbonofre
jbonofre reviewed Nov 13, 2025
View reviewed changes
Jenkinsfile
parameters {
choice(name: 'nodeLabel', choices: ['ubuntu', 's390x', 'arm', 'Windows'])
choice(name: 'jdkVersion', choices: ['jdk_17_latest', 'jdk_21_latest', 'jdk_24_latest', 'jdk_17_latest_windows', 'jdk_21_latest_windows', 'jdk_24_latest_windows'])
choice(name: 'jdkVersion', choices: ['jdk_17_latest', 'jdk_21_latest', 'jdk_25_latest', 'jdk_17_latest_windows', 'jdk_21_latest_windows', 'jdk_25_latest_windows'])
Copy link
Member

@jbonofre jbonofre Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should remove jdk_17 there already.

Copy link
Contributor Author

@mattrpav mattrpav Nov 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK 17 should stay. The new change is during release builds we need to ensure JDK 21 is used to support the multi-release jar working. The other PR has the enforce plugin set to check for JDK 21 being used only during release.

Copy link
Member

@gemmellr gemmellr Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but at least at present this PR should also be updating it to require at least 24 (I just went with requiring 25 for Artemis, sets the 25 baseline now and saves changing it later, plus who really needs to use 24 for releasing now) since thats the compilation level being used.

@jeanouii jeanouii mentioned this pull request Nov 14, 2025
Closed
@mattrpav mattrpav changed the title [#] NO-JIRA: Update Jenkinsfile to add JDK 25 [#] JDK 25 support (multiple JIRA) Nov 15, 2025
@mattrpav
Copy link
Contributor Author

mattrpav commented Nov 15, 2025

Jenkins test setup output

Running tests
+ java -version
openjdk version "25" 2025-09-16 LTS
OpenJDK Runtime Environment Temurin-25+36 (build 25+36-LTS)
OpenJDK 64-Bit Server VM Temurin-25+36 (build 25+36-LTS, mixed mode, sharing)
+ mvn -version
Apache Maven 3.9.11 (3e54c93a704957b63ee3494413a2b544fd3d825b)
Maven home: /home/jenkins/tools/maven/latest3
Java version: 25, vendor: Eclipse Adoptium, runtime: /usr/local/asfpackages/java/adoptium-jdk-25+36
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-160-generic", arch: "amd64", family: "unix"
+ mvn -B -e -fae test -Dsurefire.rerunFailingTestsCount=3

@jgallimore
Copy link
Contributor

jgallimore commented Nov 17, 2025

Looking at the Jenkins build https://ci-builds.apache.org/job/ActiveMQ/job/ActiveMQ/view/change-requests/job/PR-1533/6/cloudbees-pipeline-explorer/?filter=131 - it looks like the tests run using JDK17. Am I reading that correctly? Could we get a run with JDK25?

@mattrpav mattrpav force-pushed the NO-JIRA-Jenkinsfile-jdk-25 branch from ffdcb1c to 29bef28 Compare November 18, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbonofre jbonofre jbonofre left review comments

@gemmellr gemmellr gemmellr left review comments

Assignees

@mattrpav mattrpav

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattrpav @jgallimore @jbonofre @gemmellr