Support upper bound in provider dependencies #40465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Jun 27, 2024
jscheffl
force-pushed
the
bugfix/handle-airflow-packe-dependency-upper-limit
branch
from
99ec716
to
a9a1c08
Compare
jscheffl
added a commit
to jscheffl/airflow
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussions in https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1719428745370839 this PR provides a fix for breeze and version handling logic if an upper limit version is defined.
Foud in AIP-69 PoC PR in https://github.com/apache/airflow/actions/runs/9668809749/job/26674145127?pr=40224 as the new provider remote attempted to define the dependency to airflow as
apache-airflow>=2.10.0,<3.0as it will require Airflow 2.10 and it is assumed due to planned breaking changes it will not work with Airflow 3.0 anymore.Note: Thought about a pytest but existing pytest depends on providers and did not want to make an artificial provider upper limit. Would offer to make a test in PR #40224
related: #40224