Add asset events to dashboard #44961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
tirkarthi
force-pushed
the
dashboard-events
branch
from
c2076ee to
f69cf68
Compare
Lee-W
reviewed
Dec 17, 2024
| @@ -102,6 +102,7 @@ class AssetEventResponse(BaseModel): | |||
|
|
|||
| id: int | |||
| asset_id: int | |||
| uri: str | None = Field(alias="uri", default=None) | |||
There was a problem hiding this comment.
if we're to add uri here, we'll probably need to add name (and maybe group?)
There was a problem hiding this comment.
I’m not sure we should add uri here. If we need it in the UI, it’d be better to include the entire asset object instead.
There was a problem hiding this comment.
This is as per the initial UI design for dashboard. I am okay with changing this as per consensus.
There was a problem hiding this comment.
The designs were quite preliminary so I am happy with adding everything suggested
bbovenzi
reviewed
Dec 17, 2024
airflow/ui/src/pages/Dashboard/HistoricalMetrics/AssetEvents.tsx
Outdated
Show resolved
Hide resolved
|
Note: As PR #45312 has been merged, the code formatting rules have changed for new UI. Please rebase and re-run pre-commit checks to ensure that formatting in folder airflow/ui is adjusted. |
uranusjr
reviewed
Jan 2, 2025
airflow/ui/src/pages/Dashboard/HistoricalMetrics/AssetEvent.tsx
Outdated
Show resolved
Hide resolved
tirkarthi
force-pushed
the
dashboard-events
branch
from
f69cf68 to
f40f7e3
Compare
tirkarthi
force-pushed
the
dashboard-events
branch
from
f40f7e3 to
d7c9e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add asset events to dashboard to display the top 6 events sorted by default newest first (latest) asset events. The source links to the task instance the created the event. The selected time from filter is applied to the API to get only events in last 12 hours, past week etc. The triggered dagruns links to the dagruns triggered due to the asset event.
Notes to reviewer and self
from_rest_apiit's usually from API and source is displayed as API. Similar can be done for asset events from trigger. Opened Add from_trigger field to AssetEvent extra for events from Trigger #44944 for discussion.asset.urifor the card. Do we need to displayasset.nameorasset.uri?Related #42700