-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-72: Gracefully handle 'not-found' XCOMs in task sdk API client #45344
AIP-72: Gracefully handle 'not-found' XCOMs in task sdk API client #45344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment. But not critical to move ahead.
8862d7d
to
f8e4be0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, much simpler now :-D
@amoghrajesh - can you please rebase that one -> we found and issue with @jscheffl with the new caching scheme - fixed in #45347 that would run "main" version of the tests. I am asking in all affected PRs to rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, let me rebase this one |
Hi @uranusjr are you ok with the reply on this comment? #45344 (comment) |
7c807b7
to
482fab5
Compare
…pache#45344) * AIP-72: Gracefully handle not-found XCOMs in task sdk API client * re raising exception for non 404
closes: #45341
Testing results
DAG used:
Legacy
Task 1 XCom pushed:
Task 2 XCom consumed as None when absent:
Task SDK
Task 1 XCom pushed:
Task 2 XCom consumed as None when absent:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.