Skip to content

Conversation

foskey51
Copy link

@foskey51 foskey51 commented Oct 3, 2025

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

This PR addresses how sensitive fields are handled in Settings and Secrets by changing their input type to password and introducing a toggle to switch between masked and plain-text views.

Settings:

  • Admin Key

Behaviour:

  • Masked by default
  • Toggle icon to switch b/w text view and masked view

Secrets (page):

  • Secret Manager (section):
    • Vault
      • Token
    • AWS
      • Secret Access Key
      • Session Token
    • GCP
      • Private Key

Behaviour:

  • Masked by default
  • Toggle icon to switch b/w text view and masked view (available in edit mode only)

Related issues

fix/resolve #3218

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Change sensitive fields (admin keys, vault tokens) from input type text to password (default) with a toggle to show/hide values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Sensitive keys and tokens are visible in the APISIX Dashboard
1 participant