-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rust): make Arrow version selection more flexible #2525
base: main
Are you sure you want to change the base?
Conversation
Hmm, should we set up CI to make sure things (minus Datafusion) build with a few versions of the Rust Arrow crate? |
Testing this in CI won't work when the |
That's what I suspected. It's a tricky issue. We could discuss on the issue page the best way to decouple |
We could maybe move the datafusion driver to the datafusion repo or use two workspaces in this repo (one with the core crate and the other with the drivers)? |
The 2-workspace solution sounds good. Moving to datafusion sounds even better. Does Rust tooling assume one-repo==one-workspace anywhere? |
+1
No. |
I think we need to split workspaces for another reason: currently we claim we only need rust 1.80 but DataFusion needs rust 1.81. So I was unable to upload v0.17.0 to crates.io.
|
The driver manager doesn't have to necessarily require the same version that the datafusion driver requires (due to datafusion's specific arrow version requirements).
Fixes #2524