Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-55: Renable tests after fixing link error #595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lriggs
Copy link

@lriggs lriggs commented Feb 8, 2025

Fixes GH-55.

Rationale for this change

I fixed the linking error here: apache/arrow#45114

What changes are included in this PR?

Reenabling some disabled tests.

Are these changes tested?

Yes, they are tests.

Are there any user-facing changes?

No.

@lriggs
Copy link
Author

lriggs commented Feb 8, 2025

How do you specify the arrow version used to build/test with arrow-java (so that I know it has my fix)? Does it always use the latest?

@kou kou changed the title GH-55 Renable tests after fixing link error. GH-55: Renable tests after fixing link error. Feb 8, 2025
@kou kou changed the title GH-55: Renable tests after fixing link error. GH-55: Renable tests after fixing link error Feb 8, 2025
@kou
Copy link
Member

kou commented Feb 8, 2025

We use the latest release for push/pull request:

- name: Download the latest Apache Arrow C++
if: github.event_name != 'schedule'
run: |
ci/scripts/download_cpp.sh

We use the main branch for schedule:

- name: Checkout Apache Arrow C++
if: github.event_name == 'schedule'
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: apache/arrow
path: arrow

We need to update

VCPKG="943c5ef1c8f6b5e6ced092b242c8299caae2ff01" # 2024.04.26 Release
to use vcpkg configuration introduced by apache/arrow#45114 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java] Renable Disabled Gandiva Tests after fixing the linking error
2 participants