Let std::fmt::Debug for StructArray output Null/Validity info #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we could perhaps truncate this, or just print the null count? Most of the array implementations cap out after printing the first and last 10 elements to avoid enormous debug output generation. It isn't ideal, but we want to avoid issues where the debug output is potentially so massive, and takes so long to generate, that panics, etc... just turn into application stalls. |
|
I reused |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
When we are comparing whether two Arrays/RecordBatches are equal (e.g.,
assert_eq!(array1, array2), we also compareNullBufferinArrayData). Right now it is possible that twoStructArrays are different because of the struct-level nulls but their debug format strings are the same, which brings confusion for debugging.What changes are included in this PR?
Are there any user-facing changes?