-
Notifications
You must be signed in to change notification settings - Fork 1k
perf: add optimized zip implementation for scalars #8653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f665255
perf: add optimized zip implementation for scalars
rluvaton a0bbe7f
improve long string performance by a lot (compared to my prev impl)
rluvaton f733a25
format
rluvaton 7dd2188
Merge branch 'main' into improve-zip-for-scalars
rluvaton 98aa6bf
fix lint and format
rluvaton 7ccb30d
update comments
rluvaton 5ac9879
perf: add optimized function to create offset with same length
rluvaton e172f2e
add tests
rluvaton 3317a39
updated comment
rluvaton 5f01d05
perf: add `repeat_slice_n_times` to `MutableBuffer`
rluvaton ad3d716
Merge branch 'add-push-repeated-slice' into improve-zip-for-scalars
rluvaton 694eb72
updated with #8658 changes
rluvaton 4086174
Merge branch 'add-from-length-repeated-for-offset-buffer' into improv…
rluvaton 11f72a0
updated with #8656 changes
rluvaton 0787956
format
rluvaton 96cd9cc
add tests
rluvaton 72070dc
simplify implementation
rluvaton 9ffea3a
Merge branch 'add-push-repeated-slice' into improve-zip-for-scalars
rluvaton 37b2cda
add example and test for scalar zipper
rluvaton dd45394
add send and sync
rluvaton dabbf55
Merge branch 'main' into improve-zip-for-scalars
rluvaton 9165612
Merge branch 'main' into improve-zip-for-scalars
rluvaton c588302
Merge branch 'main' into improve-zip-for-scalars
alamb 8046f26
add more tests
rluvaton f943950
pass true in fallback zip impl
rluvaton aa276c1
lint and format
rluvaton 2f74165
add comment
rluvaton 1fcba7c
Merge branch 'main' into improve-zip-for-scalars
rluvaton 5361945
merge conflicts
rluvaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.