bench: create zip kernel benchmarks
#8654
Merged
+364
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alamb
approved these changes
Oct 19, 2025
| /// filling it with random bytes with lengths in the specified range, | ||
| /// all starting with the provided `prefix`, generated using the provided `seed`. | ||
| /// | ||
| pub fn create_binary_array_with_len_range_and_prefix_and_seed<Offset: OffsetSizeTrait>( |
Contributor
There was a problem hiding this comment.
The maze of these functions is becoming bewildering. Maybe it is time (not in this PR) to make some sort of builder API or something
| ) -> GenericBinaryArray<Offset> { | ||
| let rng = &mut seedable_rng(); | ||
| let range_rng = &mut seedable_rng(); | ||
| create_binary_array_with_seed( |
Contributor
There was a problem hiding this comment.
This is a behavior change, right (now it uses a fixed seed).
But that is an improvement as it now matches the doc comment
Member
Author
There was a problem hiding this comment.
not a behavioral change as it used the same seed
alamb
added a commit
that referenced
this pull request
Oct 28, 2025
Waiting for the PRs below to be merged first: - [x] #8654 - zip benchmarks **This PR include the following other PRs (unless merged)** to make the review easier, so please make sure to review them first - [x] #8658 - extracted from this - [x] #8656 - extracted from this # Which issue does this PR close? N/A # Rationale for this change Making zip really fast for scalars This is useful for `IF <expr> THEN <literal> ELSE <literal> END` # What changes are included in this PR? Created couple of implementation for zipping scalar, for primitive, bytes and fallback # Are these changes tested? existing tests # Are there any user-facing changes? new struct `ScalarZipper` TODO: - [x] Need to add comments if missing - [x] Add tests for decimal and timestamp to make sure the type is kept --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
I have a PR to improve zip perf for scalar but I don't see any benchmarks for it:
What changes are included in this PR?
created zip benchmarks for scalar and non scalar with different masks
Are these changes tested?
N/A
Are there any user-facing changes?
Nope