feat: add new_repeated to ByteArray
#8659
Merged
+62
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will be used in: - apache#8653
this will be used to improve performance of converting scalar to array
…peat-helpear-for-bytes-array
rluvaton
changed the title
new_repeated and try_new_repeated to ByteArraynew_repeated to ByteArray
# Conflicts: # arrow-buffer/src/buffer/mutable.rs
vegarsti
approved these changes
Nov 2, 2025
| let s: &[u8] = value.as_ref().as_ref(); | ||
| let value_offsets = OffsetBuffer::from_repeated_length(s.len(), repeat_count); | ||
| let bytes: Buffer = { | ||
| let mut mutable_buffer = MutableBuffer::with_capacity(0); |
There was a problem hiding this comment.
Why 0, do we not know how many elements?
There was a problem hiding this comment.
It is the responsibility of the repeat
And 0 will use null pointer so it will no allocate anything unnecessary
mbrobbel
reviewed
Nov 3, 2025
alamb
approved these changes
Nov 3, 2025
|
Let's get @mbrobbel 's comment addressed and we can merge this in |
|
@alamb this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include the following PRs changes please make sure to review them first
repeat_slice_n_timestoMutableBuffer#8658Which issue does this PR close?
N/A
Rationale for this change
This will make scalar to array in DataFusion faster
What changes are included in this PR?
Include the changes of:
repeat_slice_n_timestoMutableBuffer#8658Are these changes tested?
yes
Are there any user-facing changes?
yes