Update docs for zero copy conversion of ScalarBuffer #8772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
approved these changes
Nov 3, 2025
Member
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
This is helpful! One clarification.
Comment on lines
+42
to
+44
| /// // convert the buffer back to Vec without copy assuming: | ||
| /// // 1. the inner buffer is not sliced | ||
| /// // 2. the inner buffer uses standard allocation |
Member
There was a problem hiding this comment.
Is there also a requirement for the reference count of the buffer to be 1?
Member
There was a problem hiding this comment.
I think @mbrobbel 's comment applies here too #8771 (comment)
Contributor
Author
There was a problem hiding this comment.
Excellent call -- added in dac99aa. Thank you 🙏
mbrobbel
approved these changes
Nov 4, 2025
Member
|
Thanks @alamb, @wjones127 and @kylebarron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PrimitiveArrayto aVec#8771Rationale for this change
As people write more arrow kernels, let's make it easier to understand how to go back/forth to Vec without copying
What changes are included in this PR?
Add some additional information and examples about converting ScalarBuffer back/forth to Vec
Are these changes tested?
Yes by CI
Are there any user-facing changes?
Docs only. No functional change