Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Can we bump MACOSX_DEPLOYMENT_TARGET from 10.13? #45356

Closed
kou opened this issue Jan 27, 2025 · 6 comments
Closed

[R] Can we bump MACOSX_DEPLOYMENT_TARGET from 10.13? #45356

kou opened this issue Jan 27, 2025 · 6 comments

Comments

@kou
Copy link
Member

kou commented Jan 27, 2025

Describe the enhancement requested

I'm working on updating bundled AWS SDK for C++: #45306

It's for bumping minimum CMake version to 3.25: #44989

It seems that the latest AWS SDK for C++ requires macOS 10.15 or later: https://github.com/ursacomputing/crossbow/actions/runs/12983964025/job/36206123040#step:5:1166

/Users/runner/work/crossbow/crossbow/arrow/r/libarrow/dist/_deps/aws-sdk-cpp-src/src/aws-cpp-sdk-core/source/utils/memory/AWSMemory.cpp:98:19: error: 'aligned_alloc' is only available on macOS 10.15 or newer [-Werror,-Wunguarded-availability-new]
            ret = aligned_alloc(alignment, blockSize);
                  ^~~~~~~~~~~~~
/Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/malloc/_malloc.h:65:7: note: 'aligned_alloc' has been marked as being introduced in macOS 10.15 here, but the deployment target is macOS 10.13.0
void *aligned_alloc(size_t __alignment, size_t __size) __result_use_check __alloc_align(1) __alloc_size(2) _MALLOC_TYPED(malloc_type_aligned_alloc, 2) __OSX_AVAILABLE(10.15) __IOS_AVAILABLE(13.0) __TVOS_AVAILABLE(13.0) __WATCHOS_AVAILABLE(6.0);
      ^
/Users/runner/work/crossbow/crossbow/arrow/r/libarrow/dist/_deps/aws-sdk-cpp-src/src/aws-cpp-sdk-core/source/utils/memory/AWSMemory.cpp:98:19: note: enclose 'aligned_alloc' in a __builtin_available check to silence this warning
            ret = aligned_alloc(alignment, blockSize);
                  ^~~~~~~~~~~~~

Can we bump

MACOSX_DEPLOYMENT_TARGET: "10.13"
to at least "10.15"?

FYI: Wheels use "12.0": #43137

Component(s)

R

@lidavidm
Copy link
Member

If anything, every version <13 seems to be end-of-life already (though 11 and 12 got their last update recently-ish so maybe there's no need to drop them, 10.13 was last updated in 2018...)

@raulcd
Copy link
Member

raulcd commented Jan 27, 2025

@assignUser
Copy link
Member

Yes, CRAN is no longer using the 10.13 runner. I'll have to check but iirc 11 is now the lowest they test on.

@assignUser
Copy link
Member

@kou
Copy link
Member Author

kou commented Jan 27, 2025

OK. Let's use 11.6: GH-45363

kou added a commit that referenced this issue Jan 28, 2025
### Rationale for this change

CRAN uses 11.6 as the minimal macOS version now:
https://cran.r-project.org/web/checks/check_flavors.html

### What changes are included in this PR?

Update to 11.6 from 10.13.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #45356

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 20.0.0 milestone Jan 28, 2025
@kou
Copy link
Member Author

kou commented Jan 28, 2025

Issue resolved by pull request 45363
#45363

@kou kou closed this as completed Jan 28, 2025
lriggs pushed a commit to lriggs/arrow that referenced this issue Jan 30, 2025
…he#45363)

### Rationale for this change

CRAN uses 11.6 as the minimal macOS version now:
https://cran.r-project.org/web/checks/check_flavors.html

### What changes are included in this PR?

Update to 11.6 from 10.13.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#45356

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants