-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45356: [CI][R] Update MACOSX_DEPLOYMENT_TARGET to 11.6 #45363
Conversation
CRAN uses 11.6 as the minimal macOS version now: https://cran.r-project.org/web/checks/check_flavors.html
@github-actions crossbow submit r-binary-packages |
|
Revision: 5382335 Submitted crossbow builds: ursacomputing/crossbow @ actions-273f1a79dd
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 as per the issue description
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ca2f4d6. There were 8 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 50 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…he#45363) ### Rationale for this change CRAN uses 11.6 as the minimal macOS version now: https://cran.r-project.org/web/checks/check_flavors.html ### What changes are included in this PR? Update to 11.6 from 10.13. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45356 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
CRAN uses 11.6 as the minimal macOS version now:
https://cran.r-project.org/web/checks/check_flavors.html
What changes are included in this PR?
Update to 11.6 from 10.13.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
MACOSX_DEPLOYMENT_TARGET
from 10.13? #45356