GH-45344: [C++][Testing] Generic StepGenerator
#45345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @pitrou @westonpace , does this make sense? Thanks. |
zanmato1984
commented
Jan 24, 2025
| ARROW_TESTING_EXPORT std::shared_ptr<ArrayGenerator> Step(T start = 0, T step = 1) { | ||
| class StepGenerator : public ArrayGenerator { | ||
| public: | ||
| // Use [[maybe_unused]] to avoid a compiler warning in Clang versions before 15 that |
There was a problem hiding this comment.
This is weird but it seems to be a clang bug.
CI failure: https://github.com/apache/arrow/actions/runs/12952919478/job/36131370510?pr=45345
/arrow/cpp/src/arrow/testing/generator.h:313:11: error: unused type alias 'ArrowType' [-Werror,-Wunused-local-typedef]
using ArrowType = typename CTypeTraits<T>::ArrowType;
^
A SO thread: https://stackoverflow.com/questions/50205243/clang-emits-an-unused-type-alias-warning-for-a-type-alias-that-is-used
Reproduction on Clang 14: https://godbolt.org/z/hsnh6cGh8
Clang 15 (works fine): https://godbolt.org/z/x5zTe7j64
github-actions
bot
added
awaiting committer review
westonpace
approved these changes
Jan 29, 2025
github-actions
bot
added
awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#45344
What changes are included in this PR?
Make the
StepGeneratorgeneric.Are these changes tested?
UT included.
Are there any user-facing changes?
None.
StepGeneratorfor test data generation #45344