Skip to content

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Oct 21, 2025

Rationale for this change

Segfault due to combining recordbatches in concat_tables

What changes are included in this PR?

Convert to tables before combining

Are these changes tested?

Yes

Are there any user-facing changes?

No

@thisisnic thisisnic requested a review from jonkeane as a code owner October 21, 2025 10:06
@github-actions
Copy link

⚠️ GitHub issue #47000 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I'm not sure the answer is yes (or no!), but do we need to mention this in the docs for concat_tables()?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 24, 2025
@thisisnic
Copy link
Member Author

Thanks for this. I'm not sure the answer is yes (or no!), but do we need to mention this in the docs for concat_tables()?

I think we should, so I have, thanks for flagging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants