-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-44248: [FORMAT] Add TimestampWithOffset canonical extension type #48002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
serramatutu
wants to merge
12
commits into
apache:main
Choose a base branch
from
serramatutu:serramatutu/TimestampWithOffset/format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−0
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fe8056f
Add Timestamp With Offset canonical extension type
serramatutu 080220a
fixe: move timestamp offset to its own section
serramatutu d8b900f
Add note about compat with ANSI SQL
serramatutu d9a85aa
Make RFC3339 JSON a recommendation, not requirement
serramatutu 1bb212f
Add header to make it similar to other extensions
serramatutu 06ffdf9
Allow dictionary and run-end encodings for the offset
serramatutu 7520684
lidavidm's suggestion
serramatutu b0d9be3
Add section on nullability of inner buffers
serramatutu 018b5e8
Typos
serramatutu 5c3a3a8
Felipe's suggestion
serramatutu d4d50b3
Make dict and REE section more concise
serramatutu 043b07c
Implement Pitrou's suggestion
serramatutu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to say anything about what types of dictionary keys are allowed? Like is it ok to use Int8/Int16/Int32 keys -- while Int32 probably doesn't make sense as it would make the column larger, it might be necessary in some cases to encode the full range of Int16 values 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of brevity of the spec, I advised @serramatutu to not have recommendations here. I would assume anyone deciding to dictionary-encode an int16 array is considering the gains (or not) that they would have from that encoding. We are allowing but not recommending complicated encoding of an already compact 16-bit-valued array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense