Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create template for failing tests. #21728

Merged
merged 25 commits into from
Nov 21, 2022
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
78af9ad
initial template
ryanthompson591 Jun 6, 2022
a9a9752
Update .github/ISSUE_TEMPLATE/failing_test.yml
ryanthompson591 Jun 7, 2022
fa6e0c6
Update .github/ISSUE_TEMPLATE/failing_test.yml
ryanthompson591 Jun 7, 2022
354f933
added checkbox for flakey
ryanthompson591 Jun 7, 2022
f0d65f0
merge
ryanthompson591 Jun 7, 2022
209dd72
fix issue type
ryanthompson591 Jun 7, 2022
0f3e532
flaky
ryanthompson591 Jun 7, 2022
ff4ab52
added issue rules
ryanthompson591 Jun 8, 2022
a6ebfe9
Update .github/ISSUE_TEMPLATE/failing_test.yml
ryanthompson591 Nov 21, 2022
4c75c80
initial template
ryanthompson591 Jun 6, 2022
54b6629
added checkbox for flakey
ryanthompson591 Jun 7, 2022
74a11b8
Update .github/ISSUE_TEMPLATE/failing_test.yml
ryanthompson591 Jun 7, 2022
1f1b7c3
Update .github/ISSUE_TEMPLATE/failing_test.yml
ryanthompson591 Jun 7, 2022
7657fc5
fix issue type
ryanthompson591 Jun 7, 2022
ddef58a
flaky
ryanthompson591 Jun 7, 2022
e55941f
added issue rules
ryanthompson591 Jun 8, 2022
18de0b9
fixed merge
ryanthompson591 Nov 21, 2022
5b84992
changed template
ryanthompson591 Nov 21, 2022
0f40eaf
added issue rules
ryanthompson591 Jun 8, 2022
aa4c076
Merge branch 'apache:master' into failing-test-template
ryanthompson591 Nov 21, 2022
13141e4
Update .github/ISSUE_TEMPLATE/failing_test.yml
ryanthompson591 Nov 21, 2022
c37467c
Update .github/ISSUE_TEMPLATE/failing_test.yml
ryanthompson591 Nov 21, 2022
94d93a7
copied bug info so it is the same
ryanthompson591 Nov 21, 2022
e9a25bf
fixed bad template
ryanthompson591 Nov 21, 2022
f45389b
returned issue-rules to state
ryanthompson591 Nov 21, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 175 additions & 0 deletions .github/ISSUE_TEMPLATE/failing_test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,175 @@
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

name: Failing Test
description: Report a failing test
title: "[Failing Test]: "
labels: ["bug", "awaiting triage", "failing test"]
assignees:
- octocat
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this feature request! Once you've created an issue, you can self-assign by commenting `.take-issue` and you can close by commenting `.close-issue`.
Anyone can reopen a closed issue by commenting `.reopen-issue`.
You can also add/remove labels by commenting `.add-labels label1,label2,'label 3 with spaces'` or `.remove-labels label1,label2,'label 3 with spaces'`,
or with `.set-labels label1,label2,'label 3 with spaces'` (which removes any labels not in that set).
- type: textarea
id: what-happened
attributes:
label: What happened?
description: Please name which test is failing.
placeholder: |
If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.

If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
- type: dropdown
id: failure
attributes:
label: Issue Failure
options:
- "Failure: Test is flaky"
- "Failure: Test is continually failing"
validations:
required: true
- type: dropdown
id: priority
attributes:
label: Issue Priority
description: What priority is this bug? A permanently failing test should be marked P1. See https://beam.apache.org/contribute/issue-priorities for the meaning and expectations around issue priorities.
options:
- "Priority: 3"
- "Priority: 2"
- "Priority: 1"
- "Priority: 0"
validations:
required: true
- type: dropdown
id: component
attributes:
label: Issue Component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be something like "Is this test flaky or consistently failing?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is resolved.

options:
- "Component: beam-community"
- "Component: beam-model"
- "Component: beam-playground"
- "Component: build-system"
- "Component: community-metrics"
- "Component: cross-language"
- "Component: dependencies"
- "Component: dsl-dataframe"
- "Component: dsl-euphoria"
- "Component: dsl-sql"
- "Component: dsl-sql-zetasql"
- "Component: examples-java"
- "Component: examples-python"
- "Component: extensions-ideas"
- "Component: extensions-java-gcp"
- "Component: extensions-java-join-library"
- "Component: extensions-java-json"
- "Component: extensions-java-kyro"
- "Component: extensions-java-protobuf"
- "Component: extensions-java-sketching"
- "Component: extensions-java-sorter"
- "Component: infrastructure"
- "Component: io-common"
- "Component: io-go-gcp"
- "Component: io-ideas"
- "Component: io-java-amqp"
- "Component: io-java-avro"
- "Component: io-java-aws"
- "Component: io-java-azure"
- "Component: io-java-cassandra"
- "Component: io-java-cdap"
- "Component: io-java-clickhouse"
- "Component: io-java-debezium"
- "Component: io-java-elasticsearch"
- "Component: io-java-files"
- "Component: io-java-gcp"
- "Component: io-java-hadoop-file-system"
- "Component: io-java-hadoop-format"
- "Component: io-java-hbase"
- "Component: io-java-hcatalog"
- "Component: io-java-healthcare"
- "Component: io-java-influxdb"
- "Component: io-java-jdbc"
- "Component: io-java-jms"
- "Component: io-java-kafka"
- "Component: io-java-kinesis"
- "Component: io-java-kudu"
- "Component: io-java-mongodb"
- "Component: io-java-mqtt"
- "Component: io-java-parquet"
- "Component: io-java-pulsar"
- "Component: io-java-rabbitmq"
- "Component: io-java-redis"
- "Component: io-java-snowflake"
- "Component: io-java-solr"
- "Component: io-java-splunk"
- "Component: io-java-text"
- "Component: io-java-tfrecord"
- "Component: io-java-tika"
- "Component: io-java-utilities"
- "Component: io-java-xml"
- "Component: io-py-avro"
- "Component: io-py-aws"
- "Component: io-py-common"
- "Component: io-py-files"
- "Component: io-py-gcp"
- "Component: io-py-hadoop"
- "Component: io-py-ideas"
- "Component: io-py-kafka"
- "Component: io-py-mongodb"
- "Component: io-py-parquet"
- "Component: io-py-tfrecord"
- "Component: io-py-vcf"
- "Component: java-fn-execution"
- "Component: katas"
- "Component: project-management"
- "Component: release"
- "Component: run-inference"
- "Component: runner-apex"
- "Component: runner-core"
- "Component: runner-dataflow"
- "Component: runner-direct"
- "Component: runner-flink"
- "Component: runner-gearpump"
- "Component: runner-ideas"
- "Component: runner-jet"
- "Component: runner-jstorm"
- "Component: runner-mapreduce"
- "Component: runner-py-direct"
- "Component: runner-py-interactive"
- "Component: runner-ray"
- "Component: runner-samza"
- "Component: runner-spark"
- "Component: runner-tez"
- "Component: runner-twister2"
- "Component: runner-universal"
- "Component: sdk-go"
- "Component: sdk-ideas"
- "Component: sdk-java-core"
- "Component: sdk-java-harness"
- "Component: sdk-py-core"
- "Component: sdk-py-harness"
- "Component: sdk-typescript"
- "Component: test-failures"
- "Component: testing"
- "Component: testing-nexmark"
- "Component: website"
validations:
required: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add a check box as well that asks something along the lines of "Is this a known flaky test?"

I expect someone reporting a flaky test would be reasonably likely to choose this template, so it would be good to cover that one. You could even add an entry to this file -

- valueFor: 'Priority'
- so that it automatically gets labeled "flaky" (docs on how that file works are here - https://github.com/damccorm/tag-ur-it)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like no checkboxes yet.
damccorm/tag-ur-it#21

How about a dropdown with an option to mark flakey or red.

6 changes: 6 additions & 0 deletions .github/issue-rules.yml
Original file line number Diff line number Diff line change
@@ -347,3 +347,9 @@ rules:
- valueFor: 'Component'
contains: 'website'
addLabels: ['website']
- valueFor: 'Failure'
contains: 'Test is flaky'
addLabels: ['flaky', 'tests']
- valueFor: 'Failure'
contains: 'Test is continually failing'
addLabels: ['permared', 'failing test', 'tests']