Skip to content

Restore previous handling of Callables, fix bare collections types#34645

Merged
jrmccluskey merged 3 commits intoapache:masterfrom
jrmccluskey:callablecheck
Apr 17, 2025
Merged

Restore previous handling of Callables, fix bare collections types#34645
jrmccluskey merged 3 commits intoapache:masterfrom
jrmccluskey:callablecheck

Conversation

@jrmccluskey
Copy link
Copy Markdown
Contributor

Ensures that callables are not processed by type hints into other type hint instances and fixes a problem where bare collections types would throw runtime exceptions instead of being handled correctly.

First part of #34644


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey jrmccluskey merged commit a847f06 into apache:master Apr 17, 2025
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants