[TEST] [No need to reivew] Fix Spark 4.x compilation errors for Beam Spark Runner #36881
+7,540
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves all 31 compilation errors in the :runners:spark:4 module, enabling successful compilation with Spark 4.0.0-preview2, Scala 2.13, and Java 17. Key changes: 1. Scala 2.13 API Compatibility: - Replaced TraversableOnce with IterableOnce - Changed scala.Serializable to java.io.Serializable - Fixed union() method ambiguity by explicitly specifying type parameters - Modified ScalaInterop.seqOf() to return scala.collection.immutable.Seq 2. ExpressionEncoder Constructor Migration: - Implemented reflection-based approach in EncoderFactory to handle Spark 4.x API changes - Attempts to use ExpressionEncoder.apply with FlatEncoder wrappers - Added @SuppressWarnings("nullness") for Checker Framework compatibility 3. updateStateByKey Signature Adaptation: - Created Function2 adapter in SparkGroupAlsoByWindowViaWindowSet - Wrapped iterator-based UpdateStateByKeyFunction to match Spark 4.x signature - Changed from Seq to scala.collection.immutable.Seq 4. Nullness Annotations: - Added @SuppressWarnings("nullness") in EvaluationContext for Checker Framework Fixes apache#36841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves all 31 compilation errors in the :runners:spark:4 module, enabling successful compilation with Spark 4.0.0-preview2, Scala 2.13, and Java 17.
Key changes:
Scala 2.13 API Compatibility:
ExpressionEncoder Constructor Migration:
updateStateByKey Signature Adaptation:
Nullness Annotations:
Fixes #36841
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.