[CALCITE-6560] Add test in SqlParserTest

apache · Sep 4, 2024 · 912c77a · 912c77a
1 parent fb40c86
commit 912c77a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/core/src/main/java/org/apache/calcite/sql/SqlBasicTypeNameSpec.java b/core/src/main/java/org/apache/calcite/sql/SqlBasicTypeNameSpec.java
@@ -165,11 +165,11 @@ public int getPrecision() {
       writer.keyword(getTypeName().getSimple());
     }
 
-    if (sqlTypeName.allowsPrec() && (precision >= 0)) {
+    if (sqlTypeName.allowsPrec() && (precision != RelDataType.PRECISION_NOT_SPECIFIED)) {
       final SqlWriter.Frame frame =
           writer.startList(SqlWriter.FrameTypeEnum.FUN_CALL, "(", ")");
       writer.print(precision);
-      if (sqlTypeName.allowsScale() && (scale >= 0)) {
+      if (sqlTypeName.allowsScale() && (scale != RelDataType.SCALE_NOT_SPECIFIED)) {
         writer.sep(",", true);
         writer.print(scale);
       }

diff --git a/testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java b/testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java
@@ -1011,6 +1011,15 @@ protected static SortedSet<String> keywords(@Nullable String dialect) {
         .ok("SELECT 999");
   }
 
+  @Test void testDecimalWithNegativeScale() {
+    sql("select cast(15 as decimal(3, 1))")
+        .ok("SELECT CAST(15 AS DECIMAL(3, 1))");
+    sql("select cast(15 as decimal(3, -1))")
+        .ok("SELECT CAST(15 AS DECIMAL(3, -1))");
+    sql("select cast(15 as decimal(3, 0))")
+        .ok("SELECT CAST(15 AS DECIMAL(3, 0))");
+  }
+
   @Test void testDerivedColumnList() {
     sql("select * from emp as e (empno, gender) where true")
         .ok("SELECT *\n"