-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-6241] Enable a few existing functions to hive library #3948
base: main
Are you sure you want to change the base?
Conversation
@ChengJie1053 Thanks for your contribution, can you confirm that these functions give the same results in some boundary tests? In my experience, this is difficult to guarantee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't verified that indeed all these functions in Hive have the exact same behavior as the existing implementation. But assuming they do, this PR is fine.
Ok, thanks for reviewing the code for me |
Ok, thanks for reviewing the code for me, are there any other test cases I need to modify for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the adaptation of log related functions. I have not adapted the log function to hive.
Ok, thanks for reviewing the code for me, I will change the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If we discover inconsistent function semantics, we can resolve it by a new ISSUE.
Ok, thanks for reviewing the code for me |
Please remove the log function before merging. |
Ok, thanks for reviewing the code for me, I will change the code |
6f1e4a5
to
3ef2028
Compare
Hello, the code has been modified |
Can you please fix the conflicts and squash the commits in preparation for merging? |
|
Ok, thank you. I'll fix it as soon as possible |
The 1.38 release is coming soon, if you can squash the commits we can merge this. |
Ok, thank you. I tried squash commits, but failed. Can I submit a new pr |
There is no reason squashing cannot be done. Try |
Ok, thank you very much. I'll try that |
66a74bb
to
5384115
Compare
5384115
to
e35f0e0
Compare
Quality Gate passedIssues Measures |
This PR is fine, but the JIRA issue CALCITE-6241 has a different title and has been closed for 1.37. |
Unfortunately this has developed new conflicts, can you please solve these and we can now merge it. |
Tried to fix the conflict using the browser editor and I failed... sorry about this. |
@ChengJie1053 if you can fix the conflicts we can hopefully merge this |
Add hive as a supported library for functions that have already been implemented for other libraries.
Hive Functions Link:https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-ArithmeticOperators