[CALCITE-6604] Add support for SqlWindowTableFunction in RelToSql Con… #3986
+90
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verter Add WindowTableFunctionScanContext to convert RexCall(SqlWindowFunction) to SqlNdoe. First convert SqlWindowFunction to SqlCall without PARAM_DATA. Finally reconstruct a new SqlCall with PARAM_DATA as the first operand.
|
mihaibudiu
approved these changes
Sep 30, 2024
| @@ -1286,13 +1289,31 @@ public Result visit(Uncollect e) { | |||
|
|
|||
| public Result visit(TableFunctionScan e) { | |||
| final List<SqlNode> inputSqlNodes = new ArrayList<>(); | |||
| final List<SqlNode> fieldNodes = new ArrayList<>(); | |||
|
|
|||
| final int filedSize = e.getRowType().getFieldCount(); | |||
There was a problem hiding this comment.
fieldCount instead of filedSize?
mihaibudiu
added
the
LGTM-will-merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-6604
Add WindowTableFunctionScanContext to convert RexCall(SqlWindowFunction) to SqlNdoe.