Skip to content

SPARKC-516: Add column name to the error message in case of conversion error #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+11 −1
Open

SPARKC-516: Add column name to the error message in case of conversion error #1155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...cassandra-connector/src/main/scala/com/datastax/spark/connector/writer/SqlRowWriter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,11 @@ import java.util.UUID

import com.datastax.spark.connector.ColumnRef
import com.datastax.spark.connector.cql.TableDef
import com.datastax.spark.connector.types.TypeConversionException
import org.apache.spark.sql.Row

import scala.util.{Failure, Success, Try}


/** A [[RowWriter]] that can write SparkSQL `Row` objects. */
class SqlRowWriter(val table: TableDef, val selectedColumns: IndexedSeq[ColumnRef])
Expand All @@ -23,9 +26,16 @@ class SqlRowWriter(val table: TableDef, val selectedColumns: IndexedSeq[ColumnRe
require(row.size == columnNames.size, s"Invalid row size: ${row.size} instead of ${columnNames.size}.")
for (i <- 0 until row.size) {
val colValue = row(i)
buffer(i) = converters(i).convert(colValue)
buffer(i) = Try(converters(i).convert(colValue)) match {
case Success(value) => value
case Failure(ex: IllegalArgumentException) =>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most exceptions I've seen that were hard to track down were either IllegalArgumentException or its subclass.

val columnType = columnTypes(i).scalaTypeName
throw new TypeConversionException(
s"Cannot convert value $colValue of column ${columnNames(i)} to type $columnType", ex)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message will look like Cannot convert value somevalue of column somecolumn to type Int without any wrapping of somevalue (like single or double quotes). Any suggestions on how to improve readability?

case Failure(ex) => throw ex
}
}
}
}


Expand Down