CASSANDRA-20892: Don't allow JMX operations for denylist when denylist is disabled #4366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maoling
commented
Sep 5, 2025
maoling
commented
- more details in the CASSANDRA-20892
smiklosovic
reviewed
Sep 5, 2025
| return !partitionDenylist.isKeyPermitted(keyspace, table, bytes); | ||
| } | ||
|
|
||
| private void checkPartitionDenylistEnabled() { |
smiklosovic
reviewed
Sep 5, 2025
| } | ||
|
|
||
| private void checkPartitionDenylistEnabled() { | ||
| if (!getPartitionDenylistEnabled()) { |
There was a problem hiding this comment.
braces for one line is not necessary
smiklosovic
reviewed
Sep 5, 2025
| return !partitionDenylist.isKeyPermitted(keyspace, table, bytes); | ||
| } | ||
|
|
||
| private void checkPartitionDenylistEnabled() { |
There was a problem hiding this comment.
I would rename it to ensurePartitionDenylistEnabled
smiklosovic
reviewed
Sep 5, 2025
|
|
||
| private void checkPartitionDenylistEnabled() { | ||
| if (!getPartitionDenylistEnabled()) { | ||
| throw new UnsupportedOperationException("Denylisting partitions is disabled"); |
There was a problem hiding this comment.
I am not sure this is the most appropriate one. This looks like the code is not there yet. RuntimeException is probably just enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.