CEP-55 - Generation of role / user names #4379
Conversation
smiklosovic
force-pushed
the
CASSANDRA-20897
branch
from
392071d to
b63ff3b
Compare
| # Guardrail to warn or fail when setting / altering a password. | ||
| # Supported character sets are (both upper and lower-case): English, Cyrillic and modern Cyrillic, Czech, German, Polish. | ||
| # Password is invalid if all characters are from non-supported character set. If a password is otherwise valid, | ||
| # but it contains characters from unsupported language, these characters contribute only to password length rule. | ||
| # All digits and all following special characters are supported too: !"#$%&()*+,-./:;<=>?@[\]^_`{|}~ | ||
| #password_validator: | ||
| #password_policy: |
There was a problem hiding this comment.
it is better if we rename this now as this has not appeared in any release yet and it would be just too late for that otherwise. I think this better reflects what this does as it holds both generator as well as validator under one "policy". Same case for role name.
| @@ -2290,6 +2290,92 @@ drop_compact_storage_enabled: false | |||
| # maximum_replication_factor_warn_threshold: -1 | |||
| # maximum_replication_factor_fail_threshold: -1 | |||
|
|
|||
| #role_name_policy: | |||
There was a problem hiding this comment.
both policies were missing, in cassandra_latest.yaml.
| @@ -0,0 +1,4 @@ | |||
| = Role name validation and generation | |||
There was a problem hiding this comment.
This will be finished upon merge.
There was a problem hiding this comment.
Hello.
I’ve spent some time going through the code in this patch. Since I’m new to the community and not yet deeply familiar with the C* codebase, I focused mainly on spotting things like code duplications, redundant conditions, typos, and log message corrections. Hoping that this will free more experienced and more familiar with the Cassandra codebase reviewers from such things.
I also spotted this (1) misuse of ValueValidator.class for the logger of the ValueGenerator class. Since this patch already touches that class, it might be a good place to fix it as well.
src/java/org/apache/cassandra/db/guardrails/CassandraPasswordConfiguration.java
Show resolved
Hide resolved
smiklosovic
force-pushed
the
CASSANDRA-20897
branch
4 times, most recently
from
dd7410e to
075793e
Compare
smiklosovic
force-pushed
the
CASSANDRA-20897
branch
from
075793e to
dcbf8d7
Compare
Implementation of CEP-55
This patch is rather easy to go through. A lot of files were changed just because of renaming.
For reviewers, I would just focus on implementation and not bothering with tests, docs and all sauce around that. Tests are very easy to follow as well.