UI: fix list of vpc network offerings #10595
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10595 +/- ##
=============================================
- Coverage 15.16% 4.28% -10.88%
=============================================
Files 5414 368 -5046
Lines 474811 29656 -445155
Branches 57911 5206 -52705
=============================================
- Hits 72017 1272 -70745
+ Misses 394742 28239 -366503
+ Partials 8052 145 -7907
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
weizhouapache
commented
Mar 21, 2025
| @@ -553,9 +553,9 @@ export default { | |||
| if (this.publicLBExists && (idx === -1 || this.lbProviderMap.publicLb.vpc.indexOf(offering.service.map(svc => { return svc.provider[0].name })[idx]) === -1)) { | |||
| filteredOfferings.push(offering) | |||
| } else if (!this.publicLBExists && vpcLbServiceIndex > -1) { | |||
| const vpcLbServiceProvider = vpcLbServiceIndex === -1 ? undefined : this.resource.service[vpcLbServiceIndex].provider[0].name | |||
| const vpcLbServiceProviders = vpcLbServiceIndex === -1 ? undefined : this.resource.service[vpcLbServiceIndex].provider.map(provider => provider.name) | |||
There was a problem hiding this comment.
a short explanation:
- the service has two providers: InternalLbVm and VpcVirtualRouter
- without this PR, the network offerings are listed only if (1) no LB; (2) provider is InternalLbVm
- with this PR, the network offerings are listed only if (1) no LB; (2) provider is InternalLbVm; (3) provider is VpcVirtualRouter
Pearl1594
approved these changes
Mar 21, 2025
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a UI issue when create vpc tier
without this PR, only two offerings are listed
with this PR, three offerings are listed, the new one is
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?