UI: Enable listall (for Affinity Groups, SSH Keypairs, User Data) in deploy instance wizard for admin, and lists SSH Keypairs, User Data by domain/account

[sureshanaparti]

Description

This PR enables listall (for Affinity Groups, SSH Keypairs, User Data) in deploy instance wizard for admin, and lists SSH Keypairs, User Data by domain/account.

Fixes #11865

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Verified the list API calls with admin and user account, in inspect mode. and checked the SSH Keypairs, User Data listing by domain/account.

SSH Keypairs (admin account) - Before Fix:

SSH Keypairs (admin account) - After Fix:

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan ui

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.18%. Comparing base (255c461) to head (999adbd).

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11906   +/-   ##
=========================================
  Coverage     16.18%   16.18%           
- Complexity    13304    13305    +1     
=========================================
  Files          5657     5657           
  Lines        498464   498466    +2     
  Branches      60491    60491           
=========================================
+ Hits          80687    80694    +7     
+ Misses       408801   408790   -11     
- Partials       8976     8982    +6     

Flag	Coverage Δ
uitests	4.00% <ø> (-0.01%)	⬇️
unittests	17.04% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

code looks good @sureshanaparti , but as discussed over DM, I am a bit worried about cross-domain usage of keys/user-data

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11906 (QA-JID-781)

[rajujith]

Verified the UI.
LGTM

[DaanHoogland]

code looks good @sureshanaparti , but as discussed over DM, I am a bit worried about cross-domain usage of keys/user-data

Did you have a look at this @sureshanaparti ?

[sureshanaparti]

code looks good @sureshanaparti , but as discussed over DM, I am a bit worried about cross-domain usage of keys/user-data

Did you have a look at this @sureshanaparti ?

@DaanHoogland it fails with error "Not all specified keypairs exist".

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11906 (QA-JID-783)

[rajujith]

@sureshanaparti UI improvement looks good.

[DaanHoogland]

clgtm