Remove unnecessary stubbings in ManagementServerMaintenanceManagerImplTest

[harikrishna-patnala]

There are few test failures observed during build

12:29:49 [INFO] Running org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest
12:29:53 [ERROR] Tests run: 34, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.309 s <<< FAILURE! - in org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest
12:29:53 [ERROR] unnecessary Mockito stubbings(org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest)  Time elapsed: 0.037 s  <<< ERROR!
12:29:53 org.mockito.exceptions.misusing.UnnecessaryStubbingException: 
12:29:53 
12:29:53 Unnecessary stubbings detected in test class: ManagementServerMaintenanceManagerImplTest
12:29:53 Clean & maintainable test code requires zero unnecessary code.
12:29:53 Following stubbings are unnecessary (click to navigate to relevant line of code):
12:29:53   1. -> at org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest.prepareForMaintenanceAndCancelFromMaintenanceState(ManagementServerMaintenanceManagerImplTest.java:324)
12:29:53   2. -> at org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest.prepareForMaintenanceAndCancelFromPreparingForMaintenanceState(ManagementServerMaintenanceManagerImplTest.java:342)
12:29:53 Please remove unnecessary stubbings or use 'lenient' strictness. More info: javadoc for UnnecessaryStubbingException class.
12:29:53 

Description

This PR...

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (2dbc86a) to head (d7930aa).

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11914   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
+ Complexity    15542    15538    -4     
=========================================
  Files          5909     5909           
  Lines        529058   529058           
  Branches      64617    64617           
=========================================
+ Hits          92922    92936   +14     
+ Misses       425683   425667   -16     
- Partials      10453    10455    +2     

Flag	Coverage Δ
uitests	3.58% <ø> (ø)
unittests	18.63% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sureshanaparti]

check if ManagementServerMaintenanceManagerImpl::cancelMaintenanceTask() is taking the right path based on the ms host state, as these states are removed

[nvazquez]

Code LGTM