Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRYPTO-161 Add SM4 encryption support #161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wenwj0
Copy link

@wenwj0 wenwj0 commented Jun 9, 2022

add sm4-ctr and sm4-cbc in opensslCipher

@jochenw
Copy link
Contributor

jochenw commented Jun 9, 2022

Hi,

I am interested in the work, that you are doing here. Question: I notice, that your patch provides changes in the native code. That makes me hesitant: Before I accept the PR, could you help me to setup a build environment, where I can test these changes.

Background: We are considering a new release. As of now, there are no changes in the native code, so we could (in theory) just copy the native files from the previous release. But, for a release, that includes this PR, we would need a running build environment, where we can produce the updated files.

If this is interesting to you, please contact me privately at [email protected].

Thanks,

Jochen

@garydgregory
Copy link
Member

@garydgregory
Copy link
Member

We really need to update our GitHub build to deal with the C sources...

@garydgregory
Copy link
Member

We need to be able to tell GitHub builds that we need OpenSSL >= 1.1.1

@wenwj0
Copy link
Author

wenwj0 commented Jun 10, 2022

I found a warning in Java CI / build (macos-latest, 8, false): ** WARN: Could not enable JNA; detected lib VERSION 0x10000000: Error looking up function 'ENGINE_load_rdrand': dlsym(0x7ff81e7bd070, ENGINE_load_rdrand): symbol not found

Maybe the OpenSSL in Github builds is 1.0.0

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Contributor

@sebbASF sebbASF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine; however there are no tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants