Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ios): remove unused method, cordovaVersion #205

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kumo01GitHub
Copy link

@kumo01GitHub kumo01GitHub commented Dec 31, 2024

Platforms affected

iOS, browser

Motivation and Context

Cordova version is set in Objective-C and JavaScript but only use JavaScript as README.

The version information comes from the cordova.js file.

Description

Remove Objective-C method.

Testing

Tested with Simulator.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@kumo01GitHub
Copy link
Author

kumo01GitHub commented Dec 31, 2024

related issue #101

I saw the comment but device.js doesn't refer to info.cordova.

(Note: https://issues.apache.org/jira/browse/CB-5105 says "iOS is doing something special, but doing it right, so don't make any changes to iOS." but no idea what that refers to)

var buildLabel = cordova.version;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant