Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow changing location bg and text color #921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpalou
Copy link
Contributor

@dpalou dpalou commented Nov 22, 2021

Platforms affected

Android
iOS

Motivation and Context

This PR allows changing the color of the URL text (Android & iOS) and also the background color of the location bar (iOS only). The plugin allows changing the color of other elements (toolbar, navigation buttons, close button) so it makes sense to also be able to change these colors.

Description

I added 2 new options: one for Android&iOS and one for iOS only to allow changing the colors.

Testing

Open the InAppBrowser passing the options "locationcolor" and "locationtextcolor" to any value you want and check that the location background (iOS only) and text changes to the colors you specified.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant