Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mango tests using custom db name #5341

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Fix mango tests using custom db name #5341

merged 3 commits into from
Nov 26, 2024

Commits on Nov 26, 2024

  1. Add -F, --failfast to stop mango tests early on failures

    @jiahuili430
    jiahuili430 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ebd75eb View commit details
    Browse the repository at this point in the history

  2. Run mango tests with custom db instead of recreating class db 

    When running mango tests, sometimes get
`org.apache.lucene.store.NoSuchDirectoryException` error. This is because
each test in the same class used the same database name, and in the setUp
function always delete and recreate it, which caused a race condition.

Adding `setUp()` and `teadown()` to create/delete the db for each test
should solve the issue.
    @jiahuili430
    jiahuili430 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    2f6117e View commit details
    Browse the repository at this point in the history

  3. Replace recreate() with super().setUp(db_per_test=True)

    @jiahuili430
    jiahuili430 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    0bef663 View commit details
    Browse the repository at this point in the history