Fix to remove dfdl prefix for dfdl attributes if the element containi… #1197

rthomas320 · 2025-03-05T20:21:26Z

…ng the

attributes is a dfdl element
Add dfdl intellisense checklist
Add intellisense test dfdl schema files to src/tests/data
The testing checklist src/tests/DfdlIntellisenseTestingChecklist.md can be used to verify that intellisense continues to work as expected.

Closes #1080
Closes #1081
Closes #1170
Closes #1196

scholarsmate · 2025-03-06T22:53:02Z

package.json

-    "webpack": "webpack --mode production --config ./webpack/ext-dev.webpack.config.js",
+    "webpack": "webpack --mode development --config ./webpack/ext-dev.webpack.config.js",


Is this intentional? If so, why?

When debugging typescript code, hovering over variables to see their value doesn't work when webpack mode is set to production. Also variable names in the debug pane show as a, b, c, etc. instead of their actual name when webpack is set to production. I can change it back to production, but I will need to change it locally any time I want to debug typescript code.

We should keep using production mode for our builds. There may be some technique using environment variables or something so you don't need to keep changing it locally. It'll take a bit of research.

I agree with using production mode for builds and figuring out a method for having the mode change to development when debugging locally.

It looks like webpack: is specific to development to me. When I run yarn package with webpack: mode = development, yarn package uses webpack mode = production.

But, I'll change it to production.

If webpack is only used for development things, then I feel like it's fine to keep the mode as development.

src/language/providers/closeUtils.ts

src/language/providers/attributeCompletion.ts

src/language/providers/elementCompletion.ts

src/language/providers/utils.ts

scholarsmate · 2025-03-06T23:04:57Z

I see there is a testing checklist as part of this PR. If we're supposed to follow that when reviewing this change, please mention that in the PR description.

rthomas320 · 2025-03-07T11:39:11Z

I see there is a testing checklist as part of this PR. If we're supposed to follow that when reviewing this change, please mention that in the PR description.

I added a line mentioning the checklist to the description.

JeremyYao · 2025-03-07T14:39:50Z

package.json

-    "webpack": "webpack --mode production --config ./webpack/ext-dev.webpack.config.js",
+    "webpack": "webpack --mode development --config ./webpack/ext-dev.webpack.config.js",


I agree with using production mode for builds and figuring out a method for having the mode change to development when debugging locally.

JeremyYao · 2025-03-07T15:07:48Z

src/language/providers/utils.ts

@@ -49,10 +50,36 @@ const items = [
  'import',
 ]

+export class XmlItem {


Is an XmlItem a representation of a whole XML tag (<tag attr="attrval"...>) or an attribute or both?

It appears to be an XML Element. I think it ought to be renamed to something a bit more descriptive and a bit less generic. Maybe XmlElement?

It can be an XML element tag or an XML attribute. It does not represent an entire element definition. I think naming the class XmlElement would not be the correct description. The class is defined in src/language/providers/utils.ts. It is used to store and retrieve the namespace prefix and the name of the element or attribute.

Include a comment of examples of what XmlItem can represent? Like xs:element or dfdl:someAttribute? What about cases there there isn't a namespace for elements like <body></body> for example?

I don't understand your question, body isn't a dfdl element.

An XmlItem that doesn't have a namespace? I'm guessing it would be "none" from the code, but wouldn't it represent none:<whatever goes here>? Would it be better presented as private _itemNS:string | undefined = undefined? If it's undefined, it would mean the xml item doesn't belong to a namespace?

The XmlItem was introduced to keep track of the an element/attribute name and namespace. The use of none as the default values is to keep the returned results compatible with the existing code. There are various places where a return value of "none" changes the logic flow. I didn't want to re-work these situations with this change, (I was trying to get the changes in for an end of February release) but it can be looked at in future changes.

JeremyYao · 2025-03-07T15:21:18Z

src/language/providers/attributeCompletion.ts

Question: Correct me if I'm wrong, but the files under src/language/providers provide functionality for auto suggestions or completions? It also looks like it provides logic for determining when to show the completions or not that relate to DFDL and what suggestions to show?

Yes. Those TS files mostly apply to DFDL autocompletions and suggestions. Also supplies auto completion for attribute values and for changing attribute values. And provides hover definitions for attributes. Some code for TDML completion is also in those TS files.

src/tests/DfdlIintellisenseTestingChecklist.md

JeremyYao · 2025-03-14T14:23:04Z

src/language/providers/utils.ts

@@ -49,10 +50,36 @@ const items = [
  'import',
 ]

+export class XmlItem {


An XmlItem that doesn't have a namespace? I'm guessing it would be "none" from the code, but wouldn't it represent none:<whatever goes here>? Would it be better presented as private _itemNS:string | undefined = undefined? If it's undefined, it would mean the xml item doesn't belong to a namespace?

src/tests/DfdlIntellisenseTestingChecklist.md

src/tests/README.md

src/tests/DfdlIntellisenseTestingChecklist.md

…ng the attributes is a dfdl element Changed _XmlItem class name to XmlItem Changed changed XmlItem variable name to xmlItem Added dfdl intellisense checklist Added intellisense test dfdl schema files to src/tests/data Corrected line number references in intellisense testing checklist Closes apache#1080 Closes apache#1081 Closes apache#1170 Closes apache#1196

hdalsania added this to the 1.4.1 milestone Mar 6, 2025

hdalsania requested review from shanedell, scholarsmate, JeremyYao and hdalsania March 6, 2025 16:36

scholarsmate reviewed Mar 6, 2025

View reviewed changes

src/language/providers/closeUtils.ts Outdated Show resolved Hide resolved

scholarsmate reviewed Mar 6, 2025

View reviewed changes

src/language/providers/attributeCompletion.ts Outdated Show resolved Hide resolved

scholarsmate reviewed Mar 6, 2025

View reviewed changes

src/language/providers/elementCompletion.ts Outdated Show resolved Hide resolved

scholarsmate reviewed Mar 6, 2025

View reviewed changes

src/language/providers/utils.ts Outdated Show resolved Hide resolved

rthomas320 force-pushed the element-namespace-capture branch from 2b7b6de to b946931 Compare March 7, 2025 11:25

rthomas320 closed this Mar 7, 2025

rthomas320 reopened this Mar 7, 2025

JeremyYao reviewed Mar 7, 2025

View reviewed changes

rthomas320 force-pushed the element-namespace-capture branch from b946931 to a75ea76 Compare March 7, 2025 19:25

JeremyYao suggested changes Mar 10, 2025

View reviewed changes

rthomas320 force-pushed the element-namespace-capture branch 5 times, most recently from 9a64c0d to bb44853 Compare March 12, 2025 14:50

JeremyYao reviewed Mar 14, 2025

View reviewed changes

src/tests/DfdlIntellisenseTestingChecklist.md Show resolved Hide resolved

src/tests/DfdlIntellisenseTestingChecklist.md Show resolved Hide resolved

scholarsmate requested a review from JeremyYao March 14, 2025 16:30

scholarsmate assigned rthomas320 Mar 14, 2025

scholarsmate added typescript code completion Issues related to DFDL code completion capability extension Issues releated to the VSCode Extension labels Mar 14, 2025

JeremyYao approved these changes Mar 19, 2025

View reviewed changes

rthomas320 force-pushed the element-namespace-capture branch from bb44853 to e065a9b Compare March 19, 2025 14:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix to remove dfdl prefix for dfdl attributes if the element containi… #1197

Fix to remove dfdl prefix for dfdl attributes if the element containi… #1197

rthomas320 commented Mar 5, 2025 •

edited

Loading

scholarsmate Mar 6, 2025

rthomas320 Mar 7, 2025 •

edited

Loading

scholarsmate Mar 7, 2025

JeremyYao Mar 7, 2025

rthomas320 Mar 7, 2025 •

edited

Loading

JeremyYao Mar 10, 2025

scholarsmate commented Mar 6, 2025

rthomas320 commented Mar 7, 2025

JeremyYao Mar 7, 2025

JeremyYao Mar 7, 2025

scholarsmate Mar 7, 2025

rthomas320 Mar 7, 2025 •

edited

Loading

JeremyYao Mar 10, 2025

rthomas320 Mar 12, 2025 •

edited

Loading

JeremyYao Mar 14, 2025 •

edited

Loading

rthomas320 Mar 18, 2025

JeremyYao Mar 7, 2025

rthomas320 Mar 7, 2025 •

edited

Loading

JeremyYao Mar 14, 2025 •

edited

Loading

		"webpack": "webpack --mode production --config ./webpack/ext-dev.webpack.config.js",
		"webpack": "webpack --mode development --config ./webpack/ext-dev.webpack.config.js",

Fix to remove dfdl prefix for dfdl attributes if the element containi… #1197

Are you sure you want to change the base?

Fix to remove dfdl prefix for dfdl attributes if the element containi… #1197

Conversation

rthomas320 commented Mar 5, 2025 • edited Loading

Choose a reason for hiding this comment

rthomas320 Mar 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rthomas320 Mar 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scholarsmate commented Mar 6, 2025

rthomas320 commented Mar 7, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rthomas320 Mar 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rthomas320 Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

JeremyYao Mar 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rthomas320 Mar 7, 2025 • edited Loading

Choose a reason for hiding this comment

JeremyYao Mar 14, 2025 • edited Loading

Choose a reason for hiding this comment

rthomas320 commented Mar 5, 2025 •

edited

Loading

rthomas320 Mar 7, 2025 •

edited

Loading

rthomas320 Mar 7, 2025 •

edited

Loading

rthomas320 Mar 7, 2025 •

edited

Loading

rthomas320 Mar 12, 2025 •

edited

Loading

JeremyYao Mar 14, 2025 •

edited

Loading

rthomas320 Mar 7, 2025 •

edited

Loading

JeremyYao Mar 14, 2025 •

edited

Loading