Fix NamespaceDifferencesOnly Warning when namespaces are same #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-307
to
+309
| NextERDResovler -> trd: $trd\n | ||
| NextERDResovler -> looking for: $local\n | ||
| NextERDResovler -> nextERDMap: $nextERDMap\n""") | ||
| NextERDResolver -> trd: $trd\n | ||
| NextERDResolver -> looking for: $local\n | ||
| NextERDResolver -> nextERDMap: $nextERDMap\n""") |
There was a problem hiding this comment.
I stared at this way too hard trying to figure out what changed here, I might be dyslexic
olabusayoT
force-pushed
the
daf-2938-sameNamespaces
branch
from
177a142
to
c67a0fe
Compare
- currently the code doesn't check if the namespaces are the same and reports that namespaces are different as long as the local names are duplicated. This is incorrect and we add a fix that only generates the error if the namespaces are actually different - fix incorrect de-duplication of Sibs where we were overwriting the initial duplicates with the later duplicates. Now we prioritize the first "duplicates" over any secondary ones DAFFODIL-2938
olabusayoT
force-pushed
the
daf-2938-sameNamespaces
branch
from
c67a0fe
to
7e843d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAFFODIL-2938