Add test as dependency to daffodil-test-integration #1333
Conversation
|
|
||
| runCLI(args"-v parse -s $schema -r user_func1") { cli => | ||
| runCLI(args"-v parse -s $schema -r user_func1", classpath) { cli => |
There was a problem hiding this comment.
Was it intentional to not add the udfClasspath for this tests since this test is about not having any UDF's? Probably worth adding a comment to make that clear.
Though, I would have expected the CLI to succeed with UDF's on the classpath so maybe I'm missing something?
There was a problem hiding this comment.
So I think the addition of the daffodil-test as a dependency caused the internal classpath to have the UDFs available which caused the test to fail with the changes, so we had to explicitly set the the udfClasspath to be empty for it to pass.
Before we didn't need to because the daffodil-test (which contains the UDF dependencies was missing)
I can update with a comment for clarity though
There was a problem hiding this comment.
I don't think the integration tests use the same classpath used for normal tests with SBT/IDE. These tests fork witha completely custom classpath, so changes to the SBT config shouldn't affect, I think...
There was a problem hiding this comment.
Ah, and that's the problem, this test doesn't fork so it will use the normal classpath. If you specify classpath then it will fork, which is way that fixed it. Probably all the tests in here want to either specify fork = true or ensure that something is defined that causes forking, like a non-empty classpath. I think in this test case we explicitly don't want a classpath to ensure no UDFs are loaded, so we should set fork = true
- currently, we only ensure the daffodil-cli and daffodil-uds jars are built, so when some of our tests fork they can correctly reference the jars in the classpaths we set up for them. Many tests reference daffodil-test, so when you try to run daffodil-test-integration/test from a clean repo, some tests fail so we have to ensure daffodil-test is built and available as well. - add forks to cli project DAFFODIL-2933
olabusayoT
force-pushed
the
daf-2933-addTestAsDependency
branch
from
54bb5f9
to
73f631a
Compare
DAFFODIL-2933