Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide diagnosticDebugName for GroupRefFactory #1360

Merged

Conversation

olabusayoT
Copy link
Contributor

  • currently we don't have one resulting in the class name showing up in diagnostics
  • setting the diagnosticDebugNameImpl fixes the issue

DAFFODIL-2948

- currently we don't have one resulting in the class name showing up in diagnostics
- setting the diagnosticDebugNameImpl fixes the issue

DAFFODIL-2948
Copy link
Member

@stevedlawrence stevedlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@mbeckerle mbeckerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@olabusayoT olabusayoT merged commit 85529f1 into apache:main Nov 4, 2024
12 checks passed
@olabusayoT olabusayoT deleted the daf-2948-groupRefFactoryDiagnostics branch November 4, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants