Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use of DAFFODIL_TDML_API_INFOSETS enviroment variable #1365

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add use of DAFFODIL_TDML_API_INFOSETS enviroment variable #1365

wants to merge 3 commits into from
+209 −97

Commits on Nov 6, 2024

  1. Add testingParseUnparseAPIMode Tunable 

    - currently during testing we parse/unparse using both the sax and non-sax API, which leads to issues like trace running outputting twice for the same test which is confusing. We also run the parse for all out infoset outputters. With this tunable, we default to the more efficient single infoset outputter (scalaxml) and single API (non-sax) parse/unparse.
- we convert TDMLInfosetOutputter to a trait so the Full and Limited subclasses can extend it as well as TeeInfosetOutputter
- the tunable has 2 options: limited and full. with limited being the default and full being our current 2 API, all infoset outputters mode
- get rid of unused and inaccessible parse function
- add test showing use of full mode

DAFFODIL-2904
    @olabusayoT
    olabusayoT committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ec3b567 View commit details
    Browse the repository at this point in the history

  2. fixup! Add testingParseUnparseAPIMode Tunable 

    - currently during testing we parse/unparse using both the sax and non-sax API, which leads to issues like trace running outputting twice for the same test which is confusing. We also run the parse for all our infoset outputters. With this enviromental variable, we default to the more efficient single infoset outputter (scalaxml) and single API (non-sax) parse/unparse.
- the DAFFODIL_TDML_API_INFOSETS env has 2 options: 'scala' and 'all'. with scala being the default and 'all' being the current implementation of running both APIs and all infoset outputters
- refactor code to reduce duplication and remove tunable
- add cli test showing use of scala and all mode
- set CI mode to all for regression testing

DAFFODIL-2904
    @olabusayoT
    olabusayoT committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    711a262 View commit details
    Browse the repository at this point in the history

  3. fixup! fixup! Add testingParseUnparseAPIMode Tunable 

    - move cli tests to daffodil-test-integration since they require stage to run successfully

DAFFODIL-2953
    @olabusayoT
    olabusayoT committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4876133 View commit details
    Browse the repository at this point in the history