Skip to content

fix: respect ignoreNulls flag in first_value and last_value #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Apr 8, 2025

Which issue does this PR close?

Closes #1630

Rationale for this change

What changes are included in this PR?

  • Add tests
  • Fix issue

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.98%. Comparing base (f09f8af) to head (23a97cc).
Report is 131 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1626      +/-   ##
============================================
+ Coverage     56.12%   58.98%   +2.85%     
- Complexity      976     1066      +90     
============================================
  Files           119      125       +6     
  Lines         11743    12526     +783     
  Branches       2251     2339      +88     
============================================
+ Hits           6591     7388     +797     
+ Misses         4012     3973      -39     
- Partials       1140     1165      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We do not respect ignoreNulls in first_value / last_value aggregates
2 participants