Repository navigation
issue fix 26388 - #26427
Closed
rizzabhdwaj wants to merge 1 commit into
Closed
issue fix 26388#26427rizzabhdwaj wants to merge 1 commit into
rizzabhdwaj wants to merge 1 commit into
Conversation
Contributor
|
@rishabh1244 When an issue is assigned to someone, can you please ask if you can work on it before you send a PR? Please read the contributor guidelines for this recommendation as well as other suggestions for how to contribute to DataFusion. |
Author
aight ,mb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
translatepanics when output would exceed 2GB #26388Rationale for this change
String operations that produce output exceeding the supported byte-offset limits can currently panic with a
byte array offset overflowerror instead of returning a recoverable error.This PR makes string builder operations fallible so that overflow conditions are reported as
DataFusionError, preventing panics during query execution.What changes are included in this PR?
try_append_value,try_append_placeholder,try_append_with, andtry_append_byte_mapmethods to theBulkNullStringArrayBuildertrait and both implementations.StringViewArrayBuilder, includingtry_append_withandtry_append_byte_map, with rollback semantics to preserve builder state on failure.unicode/translate,unicode/reverse,core/overlay,string/repeat,string/split_part,string/chr,string/uuid, and the UTF8View path inunicode/initcap.Successful string operations retain their existing behavior, while overflow conditions now return errors instead of panicking.
What is the testing strategy for this PR?
cargo test -p datafusion-functions --lib: all 396 tests passed.Are there any user-facing changes?
String operations that exceed the supported byte-offset limits now return a
DataFusionErrorinstead of panicking. Successful operations are unaffected.