Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16934][api] When creating workflows containing switch nodes in different orders, the copied workflows may lose associations. #16939

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

llllkid
Copy link
Contributor

@llllkid llllkid commented Jan 2, 2025

Purpose of the pull request

Fix #16934

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

…ifferent orders, the copied workflows may lose associations
@llllkid
Copy link
Contributor Author

llllkid commented Jan 3, 2025

@SbloodyS @caishunfeng PTAL

@SbloodyS SbloodyS added the bug Something isn't working label Jan 6, 2025
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jan 6, 2025
@llllkid
Copy link
Contributor Author

llllkid commented Jan 16, 2025

@SbloodyS @caishunfeng @ruanwenjun PTAL

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The main diff is initialized the task code firstly.

@ruanwenjun ruanwenjun requested a review from SbloodyS January 17, 2025 03:18
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit 2ae4402 into apache:dev Jan 17, 2025
70 checks passed
@llllkid llllkid deleted the fix-16934 branch January 17, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
3 participants