Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix)[mlk] if sb_getenc is unknown, then sb_stemmer_new API will leak mem #193

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

Vallishp
Copy link

vallish@Vallishs-MacBook-Air doris-thirdparty % cat check.txt | grep memleak
src/contribs-lib/CLucene/snowball/libstemmer/libstemmer.c:42:29: error: Memory leak: stemmer [memleak]

in failure path added free for the pointer.

@Vallishp
Copy link
Author

run buildall

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye changed the title (fix)(mlk) if sb_getenc is unknown, then sb_stemmer_new API will leak mem (fix)[mlk] if sb_getenc is unknown, then sb_stemmer_new API will leak mem Feb 18, 2024
@qidaye
Copy link
Contributor

qidaye commented Feb 18, 2024

@Vallishp Please submit a PR to clucene-2.0 branch too.

@qidaye qidaye merged commit df7e5d4 into apache:clucene Feb 18, 2024
3 of 4 checks passed
@Vallishp
Copy link
Author

@Vallishp Please submit a PR to clucene-2.0 branch too.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants