Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](index compaction)Remove INT32_MAX out of destPostingQueues #198

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[fix](index compaction)Remove INT32_MAX out of destPostingQueues #198

merged 1 commit into from
Mar 12, 2024

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Mar 11, 2024

When we encounter an int32_max value during index compaction, it should not be added to the destPostingQueue.
This will cause the posting of subsequent docs to be ignored, which will cause the index file compaction to fail.

airborne12
airborne12 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zzzxl1993
zzzxl1993 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zzzxl1993
zzzxl1993 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit e9c7f1f into apache:clucene-2.0 Mar 12, 2024
3 of 4 checks passed
@qidaye qidaye deleted the fix_mow_index_compaction branch March 12, 2024 02:20
qidaye added a commit to qidaye/doris-thirdparty that referenced this pull request Mar 12, 2024
@qidaye
[fix](index compaction)Remove INT32_MAX out of destPostingQueues (apa…
1c3dd3f 
…che#198)
qidaye added a commit that referenced this pull request Mar 12, 2024
@qidaye
Pick fix mow index compaction and revert comparePostings (#199)
ef95e67 
* [fix](write)revert comparePostings due to write core (#195)

revert #156

* [fix](index compaction)Remove INT32_MAX out of destPostingQueues (#198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qidaye @airborne12 @zzzxl1993